Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83652?usp=email )
Change subject: arch/arm64/armv8/mmu: Improve log format
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83652/comment/dee9e8bf_4c037079?usp... :
PS2, Line 9: When using format string with "%p", "(nil)" will be printed for address
I mean, in that case I feel like %013p would fit better than casting everything. […]
"%013p" doesn't work:
```
src/arch/arm64/armv8/mmu.c:93:9: error: '0' flag used with '%p' gnu_printf format [-Werror=format=]
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83652?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib29c201e1b096b9c7cd750d2541923616bc858ac
Gerrit-Change-Number: 83652
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 03 Aug 2024 02:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com