[coreboot-gerrit] Change in coreboot[master]: cbfs: Remove deprecated APIs

[Werner Zeh (Code Review)]

Attention is currently required from: Christian Walter, Julius Werner.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59682 )

Change subject: cbfs: Remove deprecated APIs
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: 
Thank you for driving this topic.
I gave this CL a try on mb/siemens/mc_ehl1 and compared the timestamps with upstream.
With his CL payload loading takes twice as long, no clue yet why.
Here are the two timestamp logs for your reference (both logs are taken from the second power on so memory is trained in both cases).

Upstream timestamps:
39 entries total:

0:1st timestamp                                     36,230
  11:start of bootblock                                46,729 (10,499)
  12:end of bootblock                                  73,207 (26,478)
  13:starting to load romstage                         73,235 (27)
  14:finished loading romstage                         89,550 (16,315)
   1:start of romstage                                 89,576 (26)
 970:loading FSP-M                                     113,236 (23,660)
   2:before RAM initialization                         217,880 (104,643)
 950:calling FspMemoryInit                             224,218 (6,338)
 951:returning from FspMemoryInit                      488,743 (264,524)
   3:after RAM initialization                          497,186 (8,443)
   4:end of romstage                                   512,655 (15,468)
 100:start of postcar                                  523,149 (10,494)
 101:end of postcar                                    523,150 (0)
   8:starting to load ramstage                         523,152 (2)
  15:starting LZMA decompress (ignore for x86)         560,123 (36,970)
  16:finished LZMA decompress (ignore for x86)         575,138 (15,014)
   9:finished loading ramstage                         575,250 (112)
  10:start of ramstage                                 585,016 (9,765)
  17:starting LZ4 decompress (ignore for x86)          633,667 (48,650)
  18:finished LZ4 decompress (ignore for x86)          633,769 (102)
  30:device enumeration                                645,845 (12,076)
 971:loading FSP-S                                     652,443 (6,597)
 954:calling FspSiliconInit                            652,457 (14)
 955:returning from FspSiliconInit                     687,942 (35,485)
  40:device configuration                              729,721 (41,778)
 956:calling FspNotify(AfterPciEnumeration)            734,743 (5,022)
 957:returning from FspNotify(AfterPciEnumeration)     734,988 (244)
  50:device enable                                     734,990 (1)
  60:device initialization                             774,648 (39,657)
  70:device setup done                                 805,678 (31,029)
  75:cbmem post                                        805,686 (8)
  80:write tables                                      808,926 (3,239)
  85:finalize chips                                    817,528 (8,601)
  90:starting to load payload                          819,204 (1,676)
 958:calling FspNotify(ReadyToBoot)                    5,515,270 (4,696,065)
 959:returning from FspNotify(ReadyToBoot)             5,515,933 (662)
 960:calling FspNotify(EndOfFirmware)                  5,515,933 (0)
 961:returning from FspNotify(EndOfFirmware)           5,516,809 (876)
  99:selfboot jump                                     5,517,619 (809)

Total Time: 5,481,369

Timestamps with the CL on top of upstream:
39 entries total:

0:1st timestamp                                     36,210
  11:start of bootblock                                46,813 (10,603)
  12:end of bootblock                                  73,210 (26,396)
  13:starting to load romstage                         73,238 (27)
  14:finished loading romstage                         89,679 (16,441)
   1:start of romstage                                 89,704 (24)
 970:loading FSP-M                                     113,193 (23,489)
   2:before RAM initialization                         217,926 (104,733)
 950:calling FspMemoryInit                             224,260 (6,333)
 951:returning from FspMemoryInit                      488,756 (264,496)
   3:after RAM initialization                          497,072 (8,316)
   4:end of romstage                                   515,797 (18,724)
 100:start of postcar                                  526,325 (10,528)
 101:end of postcar                                    526,326 (0)
   8:starting to load ramstage                         526,365 (38)
  15:starting LZMA decompress (ignore for x86)         562,052 (35,687)
  16:finished LZMA decompress (ignore for x86)         576,956 (14,903)
   9:finished loading ramstage                         577,203 (247)
  10:start of ramstage                                 586,998 (9,794)
  17:starting LZ4 decompress (ignore for x86)          635,735 (48,736)
  18:finished LZ4 decompress (ignore for x86)          635,836 (101)
  30:device enumeration                                647,914 (12,077)
 971:loading FSP-S                                     654,509 (6,594)
 954:calling FspSiliconInit                            654,523 (14)
 955:returning from FspSiliconInit                     689,757 (35,234)
  40:device configuration                              729,707 (39,949)
 956:calling FspNotify(AfterPciEnumeration)            734,987 (5,279)
 957:returning from FspNotify(AfterPciEnumeration)     735,190 (203)
  50:device enable                                     735,192 (1)
  60:device initialization                             775,192 (40,000)
  70:device setup done                                 806,060 (30,868)
  75:cbmem post                                        806,069 (8)
  80:write tables                                      809,308 (3,239)
  85:finalize chips                                    817,921 (8,613)
  90:starting to load payload                          819,607 (1,685)
 958:calling FspNotify(ReadyToBoot)                    10,165,818 (9,346,210)
 959:returning from FspNotify(ReadyToBoot)             10,166,473 (655)
 960:calling FspNotify(EndOfFirmware)                  10,166,473 (0)
 961:returning from FspNotify(EndOfFirmware)           10,167,349 (875)
  99:selfboot jump                                     10,168,161 (811)

Total Time: 10,131,931