[coreboot-gerrit] Change in coreboot[master]: device: Add method to configure bus mastering based on Kconfig

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )

Change subject: device: Add method to configure bus mastering based on Kconfig
......................................................................

Patch Set 12:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig@519 
PS1, Line 519: config PCI_ALLOW_BUS_MASTER
> Right, I see the point now. […]

Done

https://review.coreboot.org/c/coreboot/+/42459/8/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/42459/8/src/device/Kconfig@520 
PS8, Line 520: Enable
> maybe: "Allow PCI bus master bit to be enabled by coreboot"? […]

I've taken over your suggestion and added a help text. I hope this is fine.

Using a linter sounds good to me.

https://review.coreboot.org/c/coreboot/+/42459/1/src/device/pci_device.c 
File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/42459/1/src/device/pci_device.c@165... 
PS1, Line 1653: void pci_configure_bus_master(const struct device *dev)
> I would prefer having inline functions in pci_ops.h to handle the PCI command register.

We are planning to expand this function in the future, since we think about adding other options too. So I would keep this for now. We can still make this inline later.