Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31420 )
Change subject: SMBIOS: Update Processor Information structure to v3.2.0 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31420/1/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/31420/1/src/include/smbios.h@377 PS1, Line 377: u16 core_count2;
yes and no :) […]
Yes and no. You are correct for values > 255, I am correct for values <= 255. Spec says about `core_count2`:
If this field is present, it holds the core count for the processor socket.
I assume for forward compatibility: Software that knows about `core_count2`, doesn't have to check `core_count` if the former is present. So adding but not setting it, i.e. `core_count2 == 0`, is wrong.