Attention is currently required from: Yu-Ping Wu, Yidi Lin.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant ......................................................................
Patch Set 10:
(4 comments)
Patchset:
PS10: sorry, I don't know why I accidentally added too many reviewers
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/ea86fd9a_7864b4ce PS9, Line 135: const struct edp_bridge *bridge;
`const struct edp_bridge *bridge = NULL;`
Done
https://review.coreboot.org/c/coreboot/+/74048/comment/4f7a32d2_1014a1f6 PS9, Line 143: else /* BOARD_GOOGLE_KRABBY_COMMON */
The static assertion above is actually for this. […]
Done, but in mipi case for starmie board, there maybe another `else if` case if remove the static assertion.
https://review.coreboot.org/c/coreboot/+/74048/comment/5d2e0328_32d32154 PS9, Line 153: assert(bridge->power_on);
Just return -1 and move to line 145. […]
Done, thank you.