Attention is currently required from: Felix Held, Jason Glenesk, Varshit Pandya.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80412?usp=email )
Change subject: vc/amd/fsp/picasso: Bring picasso inline with other AMD SoC
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/vendorcode/amd/fsp/picasso/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/80412/comment/f0ac2c36_4e14688e :
PS1, Line 59: CLK_ENABLE = 0xff,
does the fsp support this value as input?
no, it exists to be used as a test for an invalid value in pcie_gpp_dxio_update_clk_req_config()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80412?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9753acdff15921c84516ec873c925f36afdd2aa3
Gerrit-Change-Number: 80412
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 09 Feb 2024 16:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment