[coreboot-gerrit] Change in coreboot[master]: Treewide: Add '-Wduplicated-branches' warning option

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39561 )

Change subject: Treewide: Add '-Wduplicated-branches' warning option
......................................................................

Patch Set 20: Code-Review-1

(2 comments)

I feel that this is a bad idea...

https://review.coreboot.org/c/coreboot/+/39561/20/src/vendorcode/amd/agesa/f... 
File src/vendorcode/amd/agesa/f16kb/Proc/Fch/Sata/Family/Yangtze/YangtzeSataService.c:

https://review.coreboot.org/c/coreboot/+/39561/20/src/vendorcode/amd/agesa/f... 
PS20, Line 371:       AndMaskDword |= BIT10;
So now we have duplicated code, does GCC warn on that?

https://review.coreboot.org/c/coreboot/+/39561/20/src/vendorcode/amd/agesa/f... 
PS20, Line 435:       RwMem ((Bar5 + 0x0F8), AccessWidth32, 0x00FFFFFF, 0x00);
Same here