Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47776 )
Change subject: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"
......................................................................
Patch Set 1:
Patch Set 1:
I wonder if there's a reason to not overwrite this during a firmware update. Or would the ABL erase it a second time?
I would expect that without the change it would get erased twice, i.e. once during the FW update, then again during the first boot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47776
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice3d1d467c25366b7ef678cd6481d043f62644ca
Gerrit-Change-Number: 47776
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 14:44:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment