16 Jul
2020
16 Jul
'20
12:07 p.m.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43439 )
Change subject: mb/google/volteer: Add GPIO configuration table for terrador ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43439/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43439/2/src/mainboard/google/voltee... PS2, Line 16: option MAX98373_ALC5682I_I2S_TGL_Y 4
- this new audio DB type should really be defined in program.star before it is used anywhere. […]
Remove. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id22e50e3da3e2dc4ee4d01a4f71d8f651a0dcb32
Gerrit-Change-Number: 43439
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Dossym Nurmukhanov dossym@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: YH Lin yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 12:07:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali caveh@chromium.org
Gerrit-MessageType: comment