Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48749 )
Change subject: soc/intel/cnl: add panel and backlight configuration code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48749/2/src/soc/intel/cannonlake/gr...
File src/soc/intel/cannonlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/48749/2/src/soc/intel/cannonlake/gr...
PS2, Line 3: #include <commonlib/helpers.h>
: #include <device/device.h>
: #include <device/mmio.h>
: #include <device/pci_def.h>
: #include <device/resource.h>
: #include <drivers/intel/gma/i915.h>
: #include <drivers/intel/gma/i915_reg.h>
: #include <intelblocks/graphics.h>
: #include <soc/ramstage.h>
: #include <types.h>
:
commonlib/helpers.h: for rounding […]
`ramstage.h` was confusing me, it's a substitute for "chip.h". NVM
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48749
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If619b28478b4b0d18f28f318c16336e0de76e129
Gerrit-Change-Number: 48749
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 20 Dec 2020 15:29:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment