Attention is currently required from: Jason Glenesk, Martin Roth, Furquan Shaikh, Marshall Dawson, Mathew King, Angel Pons, Eric Peers, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52643 )
Change subject: soc/amd/common/acp: Move Audio Co-processor driver to common
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/block/include/amdblocks/acp.h:
https://review.coreboot.org/c/coreboot/+/52643/comment/5846326e_c03369c7
PS3, Line 22: bool acp_i2s_use_external_48mhz_osc;
this controls if the 48 MHz output from the clock generator in the FCH gets disable, so i wouldn't put in in this struct. The only connection to the ACP is indirect: the 48MHz are routed to the external audio codec chip that generates the I2S clock from the 48MHz reference and the I2S clocks are then routed to the ACP controller
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/52643/comment/c1d01bc8_5c50da9b
PS3, Line 274: bool acp_i2s_use_external_48mhz_osc;
i'd keep this one in the soc-specific code, since it's not directly acp-related
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91470ff68d1c183df9a2927d71b03371b535186a
Gerrit-Change-Number: 52643
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 28 Apr 2021 00:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment