Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31802 )
Change subject: src/soc/intel/apollolake/cpu.c: Set up local APIC
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Why not always initialize it?
Johannes wrote it a little later...of course, you can also include SeaBIOS as an ELF executable and then we don’t have the switch. I removed the switch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00b339ce1850729023db74da7f8845927a95dcc6
Gerrit-Change-Number: 31802
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Mar 2019 09:53:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment