Attention is currently required from: Arthur Heymans, Elyes Haouas, Felix Singer, Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76127?usp=email )
Change subject: acpi/acpi.c: Reduce boilerplate
......................................................................
Patch Set 3:
(3 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76127/comment/18f060f7_08ea6c15 :
PS3, Line 1875: acpi_header_t *dsdt_file = (acpi_header_t *)(*(acpi_header_t **)(dsdt_file_arg));
Is there a double cast?
https://review.coreboot.org/c/coreboot/+/76127/comment/dbdbfd9b_3c2b6880 :
PS3, Line 1904: * cbfs_unmap() uses mem_pool_free() which works correctly only
This reversed order is no longer honoured?
https://review.coreboot.org/c/coreboot/+/76127/comment/1a54d961_d5bfae00 :
PS3, Line 1914: acpi_header_t *slic_file = (acpi_header_t *)(*(acpi_header_t **)slic_file_arg);
same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76127?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4915b8cdfcfdbb34284ea75fa8a0fd23554152d
Gerrit-Change-Number: 76127
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 29 Jun 2023 19:51:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment