[coreboot-gerrit] New patch to review for coreboot: ca7897a xcompile: only enforce BFD linker on x86

[Isaac Christensen]

Isaac Christensen ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6546

-gerrit

commit ca7897a763e7f88a2d4c605e4216baa63f26137e
Author: Stefan Reinauer 
Date:   Tue Sep 10 10:55:26 2013 -0700

xcompile: only enforce BFD linker on x86

The ARM linker scripts work fine with the gold linker.
    This also requires to enhance the LINKER_SUFFIX variable
    with a platform suffix so that it can be different on
    ARMv7 and x86

Change-Id: I7d3b57991b1e40d0305be3fc4bc63d322392d98e
    Signed-off-by: Stefan Reinauer 
    Reviewed-on: https://chromium-review.googlesource.com/168771
    Reviewed-by: Ronald Minnich 
    Reviewed-by: Aaron Durbin 
    (cherry picked from commit 8b2f31e7b4996aeda5976d87971afe6cf56bef83)
    Signed-off-by: Isaac Christensen 
---
 util/xcompile/xcompile | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 01d75bf..21d8a3b 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -125,9 +125,7 @@ detect_special_flags() {
    testcc "$CC"   "$CFLAGS -Wno-unused-but-set-variable " &&
    	CFLAGS="$CFLAGS -Wno-unused-but-set-variable "

-	# Use bfd linker instead of gold if available:
-	testcc "$CC"   "$CFLAGS -fuse-ld=bfd" &&
-		CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd'
+

testcc "$CC"   "$CFLAGS -fno-stack-protector"&&
    	CFLAGS="$CFLAGS -fno-stack-protector"
@@ -138,6 +136,9 @@ detect_special_flags() {
    x86)
    	testcc "$CC"   "$CFLAGS -Wa,--divide" &&
    		CFLAGS="$CFLAGS -Wa,--divide"
+		# Use bfd linker instead of gold if available:
+		testcc "$CC"   "$CFLAGS -fuse-ld=bfd" &&
+			CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd'
    	;;
    esac
 }
@@ -150,7 +151,7 @@ CC_${TARCH}:=${GCCPREFIX}gcc
 CFLAGS_${TARCH}:=${CFLAGS}
 CPP_${TARCH}:=${GCCPREFIX}cpp
 AS_${TARCH}:=${GCCPREFIX}as ${ASFLAGS}
-LD_${TARCH}:=${GCCPREFIX}ld${LINKER_SUFFIX} ${LDFLAGS}
+LD_${TARCH}:=${GCCPREFIX}ld$(eval echo ${LINKER_SUFFIX_${TARCH}}) ${LDFLAGS}
 NM_${TARCH}:=${GCCPREFIX}nm
 OBJCOPY_${TARCH}:=${GCCPREFIX}objcopy
 OBJDUMP_${TARCH}:=${GCCPREFIX}objdump