[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/../car: Calculate SF Mask#1 based on MSR 0xc87

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51374 )

Change subject: soc/intel/common/../car: Calculate SF Mask#1 based on MSR 0xc87
......................................................................

Patch Set 9:

(1 comment)

File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/51374/comment/c014ef5e_6f99be0a 
PS9, Line 528: esi
> Sorry, `esi` holds the non-eviction mask (say, 0b00000111), `edi` holds the total number of ways (sa […]

actually, line 511 %ecx has data ways, but its not backed up, rather its being converted into non-eviction mask by like 514. Hence, we can either remove that conversion there between 512-514 and move to line 554 because mask is needed there or as you said, again do the conversion and save into another GPR?