Attention is currently required from: Andy Hsu, Hung-Te Lin, Jarried Lin.
Andy Hsu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85654?usp=email )
Change subject: soc/mediatek/mt8196: Add GPUEB support
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8196/include/soc/gpueb_priv.h:
https://review.coreboot.org/c/coreboot/+/85654/comment/9e93b37e_c023b2ea?usp... :
PS2, Line 10: #define SPM2GPUPM_CON (SPM_BASE + 0x0410) /* 0x1C004410 */
: #define SPM_REQ_STA_9 (SPM_BASE + 0x0884) /* 0x1C004884 */
: #define SPM_MFG0_PWR_CON (SPM_BASE + 0x0EA8)
Sorry, I leaved the comment accidentally. […]
After discussing with the designer, he believes that removing it should be okay.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f10dfc753f73df97ea08a4c23e97de416832be2
Gerrit-Change-Number: 85654
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Tue, 24 Dec 2024 23:46:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com