Attention is currently required from: Felix Singer, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49205 )
Change subject: device/pci_device.c: Use same indents for switch/case
......................................................................
Patch Set 3:
(1 comment)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/49205/comment/886a85a3_acb2fee4
PS3, Line 970: default:
: bad:
I can pretty much imagine why the author did it like this. How about […]
CB:772
Coding style doesn't say anything in particular. Personally, I prefer not to indent goto labels for clarity, especially when interleaved within a switch/case statement.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32
Gerrit-Change-Number: 49205
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 07 Jan 2021 21:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment