[coreboot-gerrit] Change in coreboot[master]: src: Use standard <inttypes.h>

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )

Change subject: src: Use standard <inttypes.h>
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33823/11/src/include/inttypes.h 
File src/include/inttypes.h:

https://review.coreboot.org/c/coreboot/+/33823/11/src/include/inttypes.h@71 
PS11, Line 71: #define	PRIiFAST8		"i"		/* int_fast8_t */
> You cannot pass anything smaller than an `int`, as it would […]

Yes, that's what I mean by "it doesn't actually matter as long as you pass an argument of the right type". The only time it matters is when you do something like printk(BIOS_DEBUG, "%hhi", 1000), but that's of course not valid anyway. Still, I'd say "hhi" would be more correct for PRIi8 than "i". If we set PRIi8 to "i" we should ask ourselves why we have the code handling h/hh in vtxprintf() anyway, because then it would never get used (maybe the right answer is that we should get rid of it or at least silently ignore those letters instead).