Attention is currently required from: Arthur Heymans, Eric Lai, Felix Held, Karthik Ramasubramanian, Maulik Vaghela, Nick Vaccaro, Nico Huber, Paul Menzel, Tim Wawrzynczak, sridhar siricilla.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/63552?usp=email )
Change subject: mb/google/brya: Reset XHCI controller while preparing for S5
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63552/comment/8d3abc69_ac80ae0f?usp... :
PS4, Line 37: SMI handler
This is intended to be a temporary workaround until we have a permanent solution/workaround from Intel. We suspect the permanent solution will end up in the ADL-P chipset blob collateral (i.e. not FSP), but don't know for sure yet, and this should be able to be reverted later.
_PTS may work, would have to test that there are no additional operations that happen after that runs to change the IP state again.
we don't have any solid W/A in FW space as Intel ack the issue for all ADL devices. The kernel fix implemented but we are still seeing this issue while performing poweroff before OS (and on consecutive boot, we are running into PMC IPC timeout issue)
looks like we need this CL to ensure we are booting CrOS devices after poweroff at payload/depthcharge. We have few ADL devices that are running still running from mainline (not yet branched out).
Marking this resolved and hoping we can land FW W/A as there is no other solution to fix the SoC bug for ADL devices.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63552?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf06a64f055a0cee3659b410652082f31e18e149
Gerrit-Change-Number: 63552
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik Vaghela
maulikvaghela@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maulik Vaghela
maulikvaghela@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 16 Aug 2024 11:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org