Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43757 )
Change subject: src/lib: Allow the board_reset() function to be overridden ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43757/1/src/lib/Kconfig File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/43757/1/src/lib/Kconfig@4 PS1, Line 4: need a different
provide their own
Done
https://review.coreboot.org/c/coreboot/+/43757/1/src/lib/reset.c File src/lib/reset.c:
https://review.coreboot.org/c/coreboot/+/43757/1/src/lib/reset.c@8 PS1, Line 8: CONFIG(CUSTOM_BOARD_RESET)
Can you exclude the compilation unit instead? Otherwise when CUSTOM_BOARD_RESET is set this file is […]
Sure, I guess. I'm only hesitant because if another function gets added to this file, it still won't get built in. I don't see the issue with building in a file with no code in it.
Since that's a "what if", and we can say "well, what if something gets added into the board_reset function" as well, I'm not going to worry about it right now.