Attention is currently required from: Arthur Heymans, Tim Wawrzynczak, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59317 )
Change subject: cpu/intel/model_1067x: Use apic exposed in static.c directly
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/cpu/intel/model_1067x/model_1067x_init.c:
https://review.coreboot.org/c/coreboot/+/59317/comment/4fdd015e_14b49ea9
PS2, Line 37: conf &&
This check is no longer necessary, `conf` can't be null.
https://review.coreboot.org/c/coreboot/+/59317/comment/ee6f435f_1d0748a4
PS2, Line 41: conf &&
This check is no longer necessary, `conf` can't be null.
https://review.coreboot.org/c/coreboot/+/59317/comment/f0c34af6_a0b545d7
PS2, Line 94: conf &&
This check is no longer necessary, `conf` can't be null.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa83ccf6033cbb135c7ec2e9593596dba4c6e3b5
Gerrit-Change-Number: 59317
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 20 Nov 2021 12:14:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment