Attention is currently required from: Tim Wawrzynczak, Karthik Ramasubramanian. Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility ......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS1:
I think all you are trying to do is to change the `_HID` value depending on the the fw_config values […]
Thanks a lot for your advise, I have verified that ALC5682I-VD or VS audio codec can both work normally after applying the patch you offered.
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56930/comment/60d544e9_9960b78d PS6, Line 185: register "name" = ""RT58""
suggestion: add a comment that hid is set in `ramstage.c`, e.g.: […]
Thanks for your patience and guidance that help me a lot.
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/11a992ec_e97bf49e PS6, Line 19: codec_path, ARRAY_SIZE(codec_path));
nit: this should line up with `pci_root_bus()` on the previous line
Thanks very much for your detail reminding and comment which have really teach me a lot of how to approve my coding style.
And as if adjust the line line up with `pci_root_bus()` that the overall characters may over 80, so I have adjust the line indent behind the `find_dev_nested_path()` and hope it in compliant with the requirements and readable friendly. Do you think is it appropriate ?