[coreboot-gerrit] [M] Change in coreboot[main]: drivers/intel/fsp2_0: Simplify FSP global reset definition

[Jérémy Compostella (Code Review)]

Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Paul Menzel, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh.

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84356?usp=email )

Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition
......................................................................

Patch Set 12:

(1 comment)

File src/soc/intel/common/fsp_reset.c:

https://review.coreboot.org/c/coreboot/+/84356/comment/cf24a16d_356b038b?usp... :
PS11, Line 35: CONFIG_FSP_STATUS_GLOBAL_RESET
> > > Could you show me how this is breaking older platforms running FSP spec < 2. […]

The older spec and the new specification explicitly states that the 0x4 at the beginning is specific to OEM Status code. The rest specifies the code/reset. So the lower digit values have a meaning per the specification.

The goal of the Kconfig you introduced four years ago is to map the Global Reset status to a value while the actual goal should be to map the reset required type used for Global Reset (aka. FSP_STATUS_RESET_REQUIRED_x). What `FSP_STATUS_RESET_REQUIRED_x` is used for global reset.

How do see `FSP_STATUS_GLOBAL_RESET_REQUIRED_COLD` with the current implementation ? How is COLD or WARM getting lost in this transition ?