Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Zheng Bao, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59308 )
Change subject: amdfwtool: Use address mode ......................................................................
Patch Set 2:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133447): https://review.coreboot.org/c/coreboot/+/59308/comment/8b90684c_51e04c8a PS2, Line 355: ((mode) == 2 ? (offset) - ctx.current_table : (offset)) )) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133447): https://review.coreboot.org/c/coreboot/+/59308/comment/5f7258f3_52283a03 PS2, Line 363: #define BUFF_TO_RUN_MODE(ctx, ptr, mode) RUN_OFFSET_MODE((ctx), ((char *)(ptr) - (ctx).rom), (mode)) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133447): https://review.coreboot.org/c/coreboot/+/59308/comment/b570fdac_21c3df31 PS2, Line 473: bdir->header.additional_info_fields.dir_size = table_size / 0x1000;; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133447): https://review.coreboot.org/c/coreboot/+/59308/comment/be1f0fc3_432e11f6 PS2, Line 950: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133447): https://review.coreboot.org/c/coreboot/+/59308/comment/6b7fc73c_d37e8d42 PS2, Line 956: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133447): https://review.coreboot.org/c/coreboot/+/59308/comment/b9335bce_de5dff64 PS2, Line 969: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters