[coreboot-gerrit] [L] Change in coreboot[master]: mb/bytedance: Add 2 SPR sockets server board bd_egs

[TangYiwei (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Jonathan Zhang, Lean Sheng Tan, Nill Ge, Patrick Rudolph, Paul Menzel, [e-mail].

TangYiwei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email )

Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs
......................................................................

Patch Set 3:

(25 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/75722/comment/b8f0f88e_0adfa690 :
PS1, Line 22: Signed-off-by: Yiwei Tang
> email address 'Haitao Nie' might be better as 'Haitao Nie '

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/c336b717_ad20328c :
PS1, Line 23: Reviewed-by: Haitao Nie
> email address 'Shijian Ge' might be better as 'Shijian Ge '

Please fix.

File src/mainboard/bytedance/bd_egs/include/sprsp_bd_iio.h:

https://review.coreboot.org/c/coreboot/+/75722/comment/03dcd6d3_eac62cd9 :
PS1, Line 9: #define CFG_UPD_PCIE_PORT(pexphide, slotimp, slotpsp) 	\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/eb87a01b_9598ce41 :
PS1, Line 11: 		.SLOTEIP = 0, 				\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/b530bdf5_51003c3f :
PS1, Line 12: 		.SLOTHPCAP = 0, 		\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/cfa8b0bd_aefdeb6a :
PS1, Line 13: 		.SLOTHPSUP = 0, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/50ec9880_014928d6 :
PS1, Line 14: 		.SLOTPIP = 0, 				\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/c23bd81c_03a6a31e :
PS1, Line 15: 		.SLOTAIP = 0, 				\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/6a6801b3_c0f74b92 :
PS1, Line 16: 		.SLOTMRLSP = 0, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/4b593a30_bd8cd91a :
PS1, Line 17: 		.SLOTPCP = 0, 				\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/cb58036b_7d79bc6a :
PS1, Line 18: 		.SLOTABP = 0, 				\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/90a7ea5a_c8ca4d0c :
PS1, Line 19: 		.SLOTIMP = slotimp, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/1bcb2aa5_ddca8c66 :
PS1, Line 20: 		.SLOTSPLS = 0, 				\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/6ae6e201_14039496 :
PS1, Line 21: 		.SLOTSPLV = 0, 				\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/f9ff4c48_db9ab1fa :
PS1, Line 22: 		.SLOTPSP = slotpsp, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/d750dc64_b4770d38 :
PS1, Line 23: 		.VppEnabled = 0, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/b927cece_23de7ae9 :
PS1, Line 24: 		.VppPort = 0,     			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/88278435_519e0c91 :
PS1, Line 25: 		.VppAddress = 0,          		\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/8b1f3c0a_13591c31 :
PS1, Line 26: 		.MuxAddress = 0, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/ca287b51_97084e1a :
PS1, Line 27: 		.ChannelID = 0, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/dab36fe6_49f9319f :
PS1, Line 28: 		.PciePortEnable = 1, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/6447a87d_ab15740f :
PS1, Line 29: 		.PEXPHIDE = pexphide, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/90cc1003_d57dccd5 :
PS1, Line 30: 		.HidePEXPMenu = 0, 			\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/7fcff4a7_f9049582 :
PS1, Line 31: 		.PciePortOwnership = 0, 		\
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/75722/comment/cc6acb6c_1d95d347 :
PS1, Line 32: 		.RetimerConnectCount = 0, 		\
> please, no space before tabs

Please fix.