Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36143 )
Change subject: arch/x86/boot.c: Pass arguments when running programs ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36143/3/src/arch/x86/boot.c File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/36143/3/src/arch/x86/boot.c@34 PS3, Line 34: asmlinkage
I requested this thinking about x86-32. However, I'm not sure what this decoration does when compiling for x86-64. Arthur, what's the disassembly look like with that change?
On x86-32:
2000229: 8b 44 24 04 mov 0x4(%esp),%eax 200022d: 8b 50 20 mov 0x20(%eax),%edx 2000230: 89 54 24 04 mov %edx,0x4(%esp) 2000234: ff 60 1c jmp *0x1c(%eax)
The asmlinkage flag does not change this.