Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: rework and fix platform detection ......................................................................
Patch Set 8:
Patch Set 8:
Patch Set 8:
(1 comment)
I would prefer to treat the platform detection and changes to the RP swapping in separate commits. The former can be generally useful, e.g. as simple functions is_spt() is_unp() (the LP can actually be derived from Kconfig, could still implement a func- tion for that, that acts on the config setting).
Well, atm this commit is only about platform detection. That this fixes the root port thing is just a positive side effect. I do NOT plan to add my non-fsp root port swapping implementation to this commit. This will definitely go to a follow-up commit :-)
I aggree that platform detection can be useful for other things, so what do you think about moving this directly to common code here? This is what I plan for the root port swapping implementation, too.
Hmm.. actually what I said isn't completely true. I will try to make SKU detection completely independent. Let's see..