Attention is currently required from: Arthur Heymans, Felix Singer, Lance Zhao, Lean Sheng Tan, Nico Huber.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76158?usp=email )
Change subject: acpi: Set checksum for SPCR table
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76158/comment/f775d289_7188da8e :
PS1, Line 1870: header->checksum = acpi_checksum((void *)spcr, header->length);
Doesn't `length` need to be adjusted too?
```
header->length = current - (unsigned long)spcr;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76158?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2
Gerrit-Change-Number: 76158
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 18:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment