Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: Fix platform reporting in console ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35763/3//COMMIT_MSG Commit Message:
PS3: Please mention that you chose UNP as Union-Point abbreviation.
https://review.coreboot.org/c/coreboot/+/35763/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/skylake: Fix platform reporting in console You also change identifier names and reorder platform detection which is the error-prone part. This summary hides that.
https://review.coreboot.org/c/coreboot/+/35763/3/src/soc/intel/skylake/chip_... File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35763/3/src/soc/intel/skylake/chip_... PS3, Line 156: unp nope, not anymore
https://review.coreboot.org/c/coreboot/+/35763/3/src/soc/intel/skylake/chip_... PS3, Line 160: spt nope, not anymore