Attention is currently required from: Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/85754?usp=email )
Change subject: mb/google/fatcat/var/fatcat: Modify interrupt GPIO for LPSS I2C touchpad ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/85754/comment/52efab51_d1487333?usp... : PS1, Line 443: PAD_CFG_GPI_APIC are you able to wake from sleep using touchpad ?
you might be unable to verify the wake from sleep using touchpad as S0ix not yet enabled.
I believe we should use
``` PAD_CFG_GPI_IRQ_WAKE(GPP_A13, NONE, PWROK, LEVEL, INVERT), ```
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85754/comment/80887d08_38d66244?usp... : PS1, Line 759: ACPI_IRQ_WAKE_LEVEL_LOW this configuration is now matching with gpio config
``` PAD_CFG_GPI_IRQ_WAKE(GPP_A13, NONE, PWROK, LEVEL, INVERT), ```