HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37872 )
Change subject: biostar/a68n_5200: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 11: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/37872/11/src/mainboard/biostar/a68n...
File src/mainboard/biostar/a68n_5200/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37872/11/src/mainboard/biostar/a68n...
PS11, Line 4: * Copyright (C) 2012 Advanced Micro Devices, Inc.
: * Copyright (C) 2016 Edward O'Callaghan funfunctor@folklore1984.net
: * Copyright (C) 2017,2020 Damien Zammit damien@zamaudio.com
why please ?
https://review.coreboot.org/c/coreboot/+/37872/11/src/mainboard/biostar/a68n...
PS11, Line 21: #include <arch/io.h>
not used
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e710ac61843c09a055523c7971e4c05bae56a37
Gerrit-Change-Number: 37872
Gerrit-PatchSet: 11
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Jan 2020 06:46:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
