build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63393 )
Change subject: nb/intel/gm45: Don't use __SIMPLE_DEVICE__ ......................................................................
Patch Set 1:
(9 comments)
File src/northbridge/intel/gm45/igd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/68687a38_4eea0f02 PS1, Line 18: const struct device * mch_dev = __pci_0_00_0; "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/65f3bad7_b58f684a PS1, Line 19: const struct device * peg_dev = __pci_0_01_0; "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/9f3e97d2_3258e5a7 PS1, Line 20: const struct device * igd_dev = __pci_0_02_0; "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/3dcd7b6d_51bcb0bb PS1, Line 80: const struct device * mch_dev = PCI_DEV(0, 0, 0); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/84151de9_6aa86df3 PS1, Line 101: const struct device * mch_dev = PCI_DEV(0, 0, 0); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/0a77e07a_574d99b4 PS1, Line 112: const struct device * mch_dev = PCI_DEV(0, 0, 0); "foo * bar" should be "foo *bar"
File src/northbridge/intel/gm45/iommu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/6db5380a_2fa35f07 PS1, Line 36: const struct device * igd = __pci_0_02_0; "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/11457a21_2e62c637 PS1, Line 52: const struct device * peg = __pci_0_01_0; "foo * bar" should be "foo *bar"
File src/northbridge/intel/gm45/pcie.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145485): https://review.coreboot.org/c/coreboot/+/63393/comment/8c9fc3f2_9f1a4979 PS1, Line 274: const struct device * mch = __pci_0_00_0; "foo * bar" should be "foo *bar"