Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )
Change subject: mb/google/sarien: add ish firmware_variant field to _DSD
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants...
PS8, Line 213: device usb 2.0 on end
A bit unrelated, but we should fix devicetree notation.
Those desc, type and group -registers should be defined inside the device usb 2.0 group. The configuration should be per-device, not per-chip properties.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8
Gerrit-Change-Number: 31683
Gerrit-PatchSet: 8
Gerrit-Owner: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: rushikesh s kadam
rushikesh.s.kadam@intel.com
Gerrit-Comment-Date: Fri, 15 Mar 2019 13:44:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment