Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31557 )
Change subject: rtc: Fix rtc_calc_weekday
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/31557/10/src/lib/rtc.c
File src/lib/rtc.c:
https://review.coreboot.org/#/c/31557/10/src/lib/rtc.c@120
PS10, Line 120:
nit: Please no space after casts
https://review.coreboot.org/#/c/31557/10/src/lib/rtc.c@135
PS10, Line 135: "Time: %2d:%02d:%02d\n",
nit: I don't think this line needs to be broken anymore?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibce6822942f8d9d9f39c2b6065cd785dca9e8e09
Gerrit-Change-Number: 31557
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Assignee: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 02:04:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment