Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43883 )
Change subject: mb/google/glados: Relocate devicetree settings ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... File src/mainboard/google/glados/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 41: DspEnable
I couldn't figure out if there's a dedicated device that corresponds to this option. […]
well, there is no dedicated device, but it's part of hda, so why not move it there? "something on I2C" is an AFAIU optional audio codec
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 43: SsicPortEnable
Does it correspond to a specific PCI device?
it's not its own device but part of xhci
https://review.coreboot.org/c/coreboot/+/43883/1/src/mainboard/google/glados... PS1, Line 44: Cio2Enable
Which PCI device does this correspond to?
14.3, see intel doc#334658-005 or doc#332995-003EN for example