Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39345 )
Change subject: mb/google/volteer: Enable DPTF functionality
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39345/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39345/8/src/mainboard/google/voltee...
PS8, Line 168: 60
based on the discussion, it sounds like we need different PL2 values […]
I think that's good reference based on board SKU id.
BTW, what about PL4 setting? Don't we have code for setting PL4
According to partner bug we need to set up like below.
https://partnerissuetracker.corp.google.com/issues/152639350#comment13
core L1 PL2 PL4
2c 15w 38w 71w
4c 15w 60w 105w
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd387d78bb45ca3de73f531a901d1d3f793d7bd
Gerrit-Change-Number: 39345
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Thu, 02 Apr 2020 21:03:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment