Attention is currently required from: Jonathon Hall, Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80601?usp=email )
Change subject: mb/purism/librem_cnl/var/librem_mini: Set RTC register defaults ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80601/comment/bfa25a6e_b60676ff : PS2, Line 154: io 0x60 = 0x070
you're right -- setting 0x70 does break the RTC, so this patch is no good. […]
Hmmm, best way: go back in time and prevent the soc/intel/lpc code from being moved to common/. Fixing this code would be a lot easier if we knew that no board is relying on the code.
I see two pragmatic solutions: 1. don't call the lpc_lib code for unassigned resources (i.e. check the assigned flag before the call). and then leave it unassigned and live with the BIOS_NOTICE message from pnp_device code. 2. assign a non-zero value that doesn't conflict. e.g. 0x350 might be free and would look good with the 0x360 below it :) this could, however, result in more soc/intel/lpc trouble, if it runs out of generic-decode registers.