build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29661 )
Change subject: soc/intel/braswell: Add support for FSP MR2 ......................................................................
Patch Set 6:
(10 comments)
https://review.coreboot.org/#/c/29661/6/src/mainboard/google/cyan/ramstage.c File src/mainboard/google/cyan/ramstage.c:
https://review.coreboot.org/#/c/29661/6/src/mainboard/google/cyan/ramstage.c... PS6, Line 26: params->D0Usb2Port0PerPortRXISet = config->D0Usb2Port0PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/google/cyan/ramstage.c... PS6, Line 29: params->D0Usb2Port1PerPortRXISet = config->D0Usb2Port1PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/google/cyan/ramstage.c... PS6, Line 32: params->D0Usb2Port2PerPortRXISet = config->D0Usb2Port2PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/google/cyan/ramstage.c... PS6, Line 35: params->D0Usb2Port3PerPortRXISet = config->D0Usb2Port3PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/google/cyan/ramstage.c... PS6, Line 38: params->D0Usb2Port4PerPortRXISet = config->D0Usb2Port4PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/intel/strago/ramstage.... File src/mainboard/intel/strago/ramstage.c:
https://review.coreboot.org/#/c/29661/6/src/mainboard/intel/strago/ramstage.... PS6, Line 31: params->D0Usb2Port0PerPortRXISet = config->D0Usb2Port0PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/intel/strago/ramstage.... PS6, Line 34: params->D0Usb2Port1PerPortRXISet = config->D0Usb2Port1PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/intel/strago/ramstage.... PS6, Line 37: params->D0Usb2Port2PerPortRXISet = config->D0Usb2Port2PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/intel/strago/ramstage.... PS6, Line 40: params->D0Usb2Port3PerPortRXISet = config->D0Usb2Port3PerPortRXISet; line over 80 characters
https://review.coreboot.org/#/c/29661/6/src/mainboard/intel/strago/ramstage.... PS6, Line 43: params->D0Usb2Port4PerPortRXISet = config->D0Usb2Port4PerPortRXISet; line over 80 characters