Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42884 )
Change subject: arch/x86/exception: Print stack on exception
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c
File src/arch/x86/exception.c:
https://review.coreboot.org/c/coreboot/+/42884/4/src/arch/x86/exception.c@54...
PS4, Line 549: u32
That's a good point. We should adjust the type to uintptr_t.
I'll get a patch pushed up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3822ea7aa23202ecc98612850402eeb4b1f7b5ef
Gerrit-Change-Number: 42884
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jul 2020 19:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment