Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48304 )
Change subject: soc/intel/skl: set PEG port state to auto
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Does this need testing on a lot of devices, or is it relatively safe to enable?
https://review.coreboot.org/c/coreboot/+/48304/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48304/1//COMMIT_MSG@9
PS1, Line 9: them
Nit: Does that mean the PEG ports? Maybe write it out.
https://review.coreboot.org/c/coreboot/+/48304/1//COMMIT_MSG@13
PS1, Line 13: Test: powertop on X11SSM-F shows SoC in PC8 instead of just PC3
Wow. Very nice! Maybe mention if the vendor firmware does that too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3933a219b77d7234af273217df031cf627b4071f
Gerrit-Change-Number: 48304
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Dec 2020 14:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment