Attention is currently required from: Paul Menzel, chris wang.
Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48733 )
Change subject: soc/amd/picasso: Set UPDs for tuning eDP phy
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/picasso/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/48733/comment/eacea328_b0a27074
PS3, Line 148: if (cfg->dp_phy_override) {
It seems like we should be checking for (cfg->dp_phy_override & ENABLE_EDP_TUNINGSET) here as we are only updating eDP tuning settings.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I389bc4b5726f70bb1edfd858dba1c575cf68050b
Gerrit-Change-Number: 48733
Gerrit-PatchSet: 3
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Thu, 14 Jan 2021 18:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment