13 Oct
2019
13 Oct
'19
12:32 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35999 )
Change subject: gma: Fix GTT size reading for Gen8+ ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/35999/2/common/hw-gfx-gma.adb File common/hw-gfx-gma.adb:
https://review.coreboot.org/c/libgfxinit/+/35999/2/common/hw-gfx-gma.adb@697 PS2, Line 697: Natural (Shift_Left (Word32'(1), 20 + GGMS_Gen8 (GGC))) else 0); The prover didn't like the exponentiation. actually I would have expected the opposite, that it fails to prove the shift result...
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/35999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I13e40ad1d389d389c6fab6b2b42895179649f6da
Gerrit-Change-Number: 35999
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Sun, 13 Oct 2019 00:32:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment