Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31661 )
Change subject: soc/intel/braswell: Add SMBus support ......................................................................
Patch Set 3:
Patch Set 2:
I had a similar idea when I got a Braswell board with DIMM slot. What I did was to select SOC_INTEL_COMMON_BLOCK and SOC_INTEL_COMMON_BLOCK_SMBUS on mainboard specific options. It worked almost out of the box. There are few dependencies like soc/smbus.h file which needs: SMB_RCV_SLVA and SMBUS_SLAVE_ADDR values defined. Also, there is a need to define PCH_DEV_SMBUS elsewhere. How about that kind of approach?
The SoC common smbus only supports smbus byte read/write. The board is using I2C block write. The block functions (except i2c write) are already available in southbridge common. Therefor using SB common was the easiest.
I assume using SB common works for DIMM slot also?