Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43358 )
Change subject: cbgfx: Add blend functions to calculate transparency ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43358/5/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/43358/5/payloads/libpayload/drivers... PS5, Line 189:
nit: should technically indent one space less here, if you're trying to match parentheses
Done
https://review.coreboot.org/c/coreboot/+/43358/5/payloads/libpayload/include... File payloads/libpayload/include/cbgfx.h:
https://review.coreboot.org/c/coreboot/+/43358/5/payloads/libpayload/include... PS5, Line 215: * Set alpha values to setup transparency calculations
This isn't a super good explanation of what it really does (and also no relation to the explanation […]
Ack. Updated description.
https://review.coreboot.org/c/coreboot/+/43358/5/payloads/libpayload/include... PS5, Line 220: * 256 = completely opaque
Same here (see below)... 255 is the largest legal value.
Done
https://review.coreboot.org/c/coreboot/+/43358/5/payloads/libpayload/include... PS5, Line 236: * 256 = 100% opacity
Except that that one is illegal and will be treated as 0 because the parameter to set_blend() can on […]
Done. Added MIN so we don't go above 255.