Martin Roth has posted comments on this change. ( https://review.coreboot.org/19958 )
Change subject: haswell: add CBMEM_MEMINFO table when initing RAM ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/19958/2/src/northbridge/intel/haswell/ramini... File src/northbridge/intel/haswell/raminit.c:
https://review.coreboot.org/#/c/19958/2/src/northbridge/intel/haswell/ramini... PS2, Line 203: 0x18 MEMORY_TYPE_DDR is implemented in include/smbios.h
https://review.coreboot.org/#/c/19958/2/src/northbridge/intel/haswell/ramini... PS2, Line 210: 122 Adding a include/spd_ddr3.h file similar to the spd_ddr2.h file for these fields would be nice.
https://review.coreboot.org/#/c/19958/2/src/northbridge/intel/haswell/ramini... PS2, Line 218: //SPD_SODIMM Should we detect this, or will this code only be for laptops?
https://review.coreboot.org/#/c/19958/2/src/northbridge/intel/haswell/ramini... PS2, Line 218: 3 Is this an SPD field or a SMBIOS field? Use a #define?