[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Use MEM_CH_SEL to indicate single_channel sku

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31358 )

Change subject: mb/google/hatch: Use MEM_CH_SEL to indicate single_channel sku
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31358/3/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/memory.c:

https://review.coreboot.org/#/c/31358/3/src/mainboard/google/hatch/variants/... 
PS3, Line 22: 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            : 
            :
> yeah, this was not straightforward. […]

But why not just have:

static struct cnl_mb_cfg baseboard_memcfg = {

...

};

here and then:

const struct cnl_mb_cfg *__weak variant_memory_params(void)
{
    if (gpio_get(GPP_F2) == 1)
    baseboard_memcfg.single_channel = 1;

return &baseboard_memcfg;
}