Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38454 )
Change subject: mainboard/puff: Fix ACPI tables to advertise correct features ......................................................................
Patch Set 3:
(4 comments)
Patch Set 3:
I think we still need this, #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
+1
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 30: EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) This won't be required for Puff. It is based on mode change between laptop <-> tablet mode.
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 45: EC_HOST_EVENT_KEY_PRESSED This won't be required for Puff. It is basically keyboard controller on the EC indicating a key press.
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 46: EC_HOST_EVENT_MODE_CHANGE This won't be required for Puff.
https://review.coreboot.org/c/coreboot/+/38454/3/src/mainboard/google/hatch/... PS3, Line 55: EC_HOST_EVENT_BATTERY_SHUTDOWN I don't think this will be required?