Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/nissa/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/mainboard/google/brya/variants/anraggar/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79730/comment/0d556296_e2c99bf9 :
PS3, Line 8: ramstage-y += variant.c
Check that files end with a single newline (lint-extended-015-final-newlines): src/mainboard/google/ […]
Done
File src/mainboard/google/brya/variants/anraggar/variant.c:
https://review.coreboot.org/c/coreboot/+/79730/comment/0e23e540_b83ac5fb :
PS2, Line 7: return "wifi_sar_2.hex";
add tab
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 5
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tao Yang
yangtao6@huaqin.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 27 Dec 2023 01:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment