Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69138 )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/nissa/var/craask: Disable stylus GPIO pins based on fw_config ......................................................................
mb/google/nissa/var/craask: Disable stylus GPIO pins based on fw_config
BUG=b:257879909 Test:Boot to OS on craask and check stylus GPIO pins
Signed-off-by: Tyler Wang tyler.wang@quanta.corp-partner.google.com Change-Id: I7e3a2583187c8a8e2616a5272b5a7a61debe982b Reviewed-on: https://review.coreboot.org/c/coreboot/+/69138 Reviewed-by: Tarun Tuli taruntuli@google.com Reviewed-by: Reka Norman rekanorman@chromium.org Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/craask/fw_config.c 1 file changed, 31 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kangheui Won: Looks good to me, approved Reka Norman: Looks good to me, approved Eric Lai: Looks good to me, approved Tarun Tuli: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brya/variants/craask/fw_config.c b/src/mainboard/google/brya/variants/craask/fw_config.c index 602eeab..5b8f058 100644 --- a/src/mainboard/google/brya/variants/craask/fw_config.c +++ b/src/mainboard/google/brya/variants/craask/fw_config.c @@ -42,6 +42,13 @@ PAD_NC_LOCK(GPP_H13, NONE, LOCK_CONFIG), };
+static const struct pad_config stylus_disable_pads[] = { + /* F13 : SOC_PEN_DETECT_R_ODL */ + PAD_NC_LOCK(GPP_F13, NONE, LOCK_CONFIG), + /* F15 : SOC_PEN_DETECT_ODL */ + PAD_NC_LOCK(GPP_F15, NONE, LOCK_CONFIG), +}; + void fw_config_gpio_padbased_override(struct pad_config *padbased_table) { if (!fw_config_probe(FW_CONFIG(DB_USB, DB_1C_LTE))) { @@ -62,4 +69,9 @@ ARRAY_SIZE(sd_disable_pads)); }
+ if (fw_config_probe(FW_CONFIG(STYLUS, STYLUS_ABSENT))) { + printk(BIOS_INFO, "Disable Stylus GPIO pins.\n"); + gpio_padbased_override(padbased_table, stylus_disable_pads, + ARRAY_SIZE(stylus_disable_pads)); + } }