Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61478 )
Change subject: mb/**/Kconfig: Properly override `DISABLE_HECI1_AT_PRE_BOOT` ......................................................................
mb/**/Kconfig: Properly override `DISABLE_HECI1_AT_PRE_BOOT`
Don't unconditionally override `DISABLE_HECI1_AT_PRE_BOOT`.
Change-Id: I7d447e73f672877c76eecea1eb8b8f41f89ce686 Fixes: commit a0d9ad322fe603d4d4cbccda9c7edcfbf0b13409 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/61478 Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/fizz/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/kontron/bsl6/Kconfig 3 files changed, 9 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index d9b73bb..3e2b8c1 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -23,9 +23,6 @@ select RT8168_SUPPORT_LEGACY_VPD_MAC select RT8168_SET_LED_MODE
-config DISABLE_HECI1_AT_PRE_BOOT - default y - config BOARD_GOOGLE_FIZZ select BOARD_GOOGLE_BASEBOARD_FIZZ
@@ -40,6 +37,9 @@
if BOARD_GOOGLE_BASEBOARD_FIZZ
+config DISABLE_HECI1_AT_PRE_BOOT + default y + config IGNORE_IASL_MISSING_DEPENDENCY def_bool y
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index f87f8fd..68e4f71 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -21,9 +21,6 @@ select SOC_INTEL_SKYLAKE select SYSTEM_TYPE_LAPTOP
-config DISABLE_HECI1_AT_PRE_BOOT - default y - config BOARD_GOOGLE_ASUKA select BOARD_GOOGLE_BASEBOARD_GLADOS select DRIVERS_GENERIC_MAX98357A @@ -78,6 +75,9 @@
if BOARD_GOOGLE_BASEBOARD_GLADOS
+config DISABLE_HECI1_AT_PRE_BOOT + default y + config IGNORE_IASL_MISSING_DEPENDENCY def_bool y
diff --git a/src/mainboard/kontron/bsl6/Kconfig b/src/mainboard/kontron/bsl6/Kconfig index 78e81c4..782f560 100644 --- a/src/mainboard/kontron/bsl6/Kconfig +++ b/src/mainboard/kontron/bsl6/Kconfig @@ -15,9 +15,6 @@ select MAINBOARD_HAS_LIBGFXINIT select DRIVERS_I2C_NCT7802Y
-config DISABLE_HECI1_AT_PRE_BOOT - default y - config BOARD_KONTRON_BSL6 select BOARD_KONTRON_BSL6_COMMON select HAVE_ACPI_RESUME @@ -29,6 +26,9 @@
if BOARD_KONTRON_BSL6_COMMON
+config DISABLE_HECI1_AT_PRE_BOOT + default y + config MAINBOARD_DIR default "kontron/bsl6"